Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase node 12 support to ^12.13 #2771

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Conversation

lukekarrys
Copy link
Member

@lukekarrys lukekarrys commented Dec 9, 2022

Checklist
Description of change

npm@8 updated to node-gyp@9 which was technically a breaking change for us due to the mismatch of the lower bound of node 12 support. this was done by mistake but we opted not to revert since by the time we noticed we were more concerned that changing node-gyp versions would break more things.

changing the lower bound of node 12 to 12.13 will align with npm 8 and allow us to fix our breaking change without needing to do a bunch of back ports.

Ref #2753 (comment)
Ref npm/cli#5049 (comment)

@lukekarrys lukekarrys marked this pull request as ready for review December 9, 2022 16:38
@lukekarrys
Copy link
Member Author

#2772 addresses the test failures which are unrelated to the changes in this PR

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3 thank you

@lukekarrys lukekarrys mentioned this pull request Dec 10, 2022
2 tasks
@lukekarrys
Copy link
Member Author

@nodejs/node-gyp friendly ping to help this get reviewed. ideally this could get released in 9.3.1, since i have breaking changes for review in #2770.

@cclauss cclauss merged commit 888efb9 into nodejs:main Dec 16, 2022
@lukekarrys lukekarrys deleted the node-12-engines branch December 16, 2022 22:33
@ljharb
Copy link
Member

ljharb commented Dec 16, 2022

@cclauss thanks! how soon do you think a v9 patch release could be cut?

ljharb added a commit to ljharb/aud that referenced this pull request Dec 19, 2022
ljharb added a commit to ljharb/npm-lockfile that referenced this pull request Dec 19, 2022
ljharb added a commit to ljharb/get-dep-tree that referenced this pull request Dec 19, 2022
ljharb added a commit to ljharb/ls-publishers that referenced this pull request Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants